Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Delete Function #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Delete Function #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions __init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,10 @@ def delete(cls, challenge):
:return:
"""
solve_ids = Solves.query.with_entities(Solves.id).filter_by(challenge_id=challenge.id).subquery()
award_ids = FirstBloodAward.query.with_entities(FirstBloodAward.id).filter(FirstBloodAward.solve_id.in_(solve_ids)).subquery()
Awards.query.filter(Awards.id.in_(award_ids)).delete(synchronize_session='fetch')
first_blood_awards = FirstBloodAward.query.filter(FirstBloodAward.solve_id.in_(solve_ids)).all()
for award in first_blood_awards:
db.session.delete(award)
db.session.commit()
super().delete(challenge)

@classmethod
Expand Down Expand Up @@ -236,14 +238,9 @@ def recalculate_awards(cls, challenge):

@event.listens_for(Session, "after_bulk_delete")
def after_bulk_delete(delete_context):
if delete_context.primary_table.name == "solves":
# A batch delete of solves just occured
# This usually means that CTFd is removing a user account
# Why do they do this differently for users and teams? No idea ¯\_(ツ)_/¯

# Mark ALL first blood challenges for recalculation
# TODO: It would probably be better to detect which solves got removed and which challenges are affected - but before_bulk_delete doesn't seem to be a thing and the rows are already removed by now
for challenge in Challenges.query.filter_by(type="firstblood").all():
if 'solves' in str(delete_context.query):
challenges = Challenges.query.filter_by(type="firstblood").all()
for challenge in challenges:
FirstBloodValueChallenge.recalculate_awards(challenge)

@event.listens_for(Session, "before_flush")
Expand Down