Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework .toPython() to use common StringBuilder, not plain Strings #72

Open
krzema12 opened this issue Nov 23, 2021 · 3 comments
Open

Rework .toPython() to use common StringBuilder, not plain Strings #72

krzema12 opened this issue Nov 23, 2021 · 3 comments
Labels
cleanliness Let's polish our code!

Comments

@krzema12
Copy link
Owner

Originally created by @SerVB.
@krzema12 krzema12 added the optimization This change would result in a more optimal Python; "Pythonification". label Nov 23, 2021
@SerVB SerVB added cleanliness Let's polish our code! and removed optimization This change would result in a more optimal Python; "Pythonification". labels Nov 26, 2021
@SerVB SerVB changed the title [Cleanless] Rework .toPython() to use common StringBuilder, not plain Strings Rework .toPython() to use common StringBuilder, not plain Strings Nov 26, 2021
@SerVB
Copy link
Collaborator

SerVB commented Nov 26, 2021

I already tried that some time ago but AFAIR it didn't give much boost: https://github.com/krzema12/kotlin-python/tree/2021-07-30-stringbuilder

@krzema12
Copy link
Owner Author

Yeah, I guess we concluded that the current code looks and works good enough. Feel free to close this one if you want.

@SerVB
Copy link
Collaborator

SerVB commented Nov 26, 2021 •
edited
Loading

Let's leave it open until one more try in the far future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanliness Let's polish our code!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krzema12 @SerVB