-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build & run errors with latest wasm tools #69
Comments
I blame that one on the Cube2 build system running ENet's configure step during make ;)
I think we used to define that, and still do for compatibility's sake in the asm.js backend. Anyhow, the we should use the proper I do see a runtime failure though, so something seems to have broken here. |
Hey, maybe @lsalzman could fix that then :P |
You missed some, e.g. |
Thanks, fixed. Also fixed some options that needed updating after recent emscripten changes. It now works in -O2, but not -Os (which uses the new metadce stuff, which apparently has a bug). |
Ok, I figured out the JSDCE bug, fix is in emscripten-core/emscripten#5965 . That replaces the previous PR, which was not correct. With the later PR in emscripten, everything looks ok, at least using the default asm2wasm path. Does it work with the wasm backend too? |
With Emscripten and BananaBread from today, building now works fine, running still gives |
Ah, that's a recent filesystem emulation change on emscripten. Fixed on master now. |
I'm sure this has something to do with me using tools from https://wasm-stat.us/waterfall, but wanted to report it anyway just in case any of these problems are worth fixing:
First, I got:
Thanks to the helpful error message that was quick to fix, but I wasn't expecting this when running make.
Second, I had to add
-DEMSCRIPTEN=1
to the Makefile to make it build. Not sure where this normally comes from.Then when running, it manages to init most of the engine, when it gets to:
There's also still quite a few warnings that may have popped up because of the recent clang, and some messages saying it can't find SDL_Image and similar, but that doesn't appear to prevent it from building.
The text was updated successfully, but these errors were encountered: