-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX build fails on zlib.h being missing. #52
Comments
Oh, I see we had this change: emscripten-core/emscripten@409051c which breaks it. |
What are you building there? If that is a project that uses zlib, it should include the zlib headers. We had them by mistake in our system headers, but we don't have the code there, so we removed the header. |
I was building BananaBread for Emscripten using these instructions: https://github.com/kripken/BananaBread |
Ok, i guess that project needs to import zlib headers then. |
Was this fixed in 0b96d97 ? |
Seems so, at least in that branch. On Wed, Sep 3, 2014 at 2:11 PM, Nick Desaulniers [email protected]
|
I've checked out the worker branch, but when I run |
No, we just need to copy zlib.h into here somewhere, I guess. I thought I already had into at least one branch, but maybe no. |
If I add |
If I simply curl zconf.h into the dir, building proceeds. PR inbound. |
Unfortunately, looks like we can't use crunch on OSX. @juj seems to already have run into this one... |
You can install crunch via Emscripten SDK on OSX (type |
@juj , can I install crunch given emscripten's source, instead of having to install the sdk? |
add zconf.h header for OSX builds Fixes #52
Tried to build on OSX with latest emscripten, but the build aborts on a missing include zlib.h:
http://pastebin.com/GhNBsetv
Did OSX builds work at some point - is this a regression? Or I wonder if OSX hasn't been used before to build?
The text was updated successfully, but these errors were encountered: