Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX build fails on zlib.h being missing. #52

Open
juj opened this issue Jul 29, 2014 · 13 comments
Open

OSX build fails on zlib.h being missing. #52

juj opened this issue Jul 29, 2014 · 13 comments

Comments

@juj
Copy link

juj commented Jul 29, 2014

Tried to build on OSX with latest emscripten, but the build aborts on a missing include zlib.h:

http://pastebin.com/GhNBsetv

Did OSX builds work at some point - is this a regression? Or I wonder if OSX hasn't been used before to build?

@juj
Copy link
Author

juj commented Jul 29, 2014

Oh, I see we had this change: emscripten-core/emscripten@409051c which breaks it.

@kripken
Copy link
Owner

kripken commented Jul 29, 2014

What are you building there?

If that is a project that uses zlib, it should include the zlib headers. We had them by mistake in our system headers, but we don't have the code there, so we removed the header.

@juj
Copy link
Author

juj commented Jul 29, 2014

I was building BananaBread for Emscripten using these instructions: https://github.com/kripken/BananaBread

@kripken
Copy link
Owner

kripken commented Jul 29, 2014

Ok, i guess that project needs to import zlib headers then.

@nickdesaulniers
Copy link

Was this fixed in 0b96d97 ?

@kripken
Copy link
Owner

kripken commented Sep 3, 2014

Seems so, at least in that branch.

On Wed, Sep 3, 2014 at 2:11 PM, Nick Desaulniers [email protected]
wrote:

Was this fixed in 0b96d97
0b96d97
?


Reply to this email directly or view it on GitHub
#52 (comment).

@nickdesaulniers
Copy link

I've checked out the worker branch, but when I run emmake make, I still get 'zlib.h' file not found. Do I need to add an addition -I flag?

@kripken
Copy link
Owner

kripken commented Sep 8, 2014

No, we just need to copy zlib.h into here somewhere, I guess. I thought I already had into at least one branch, but maybe no.

@nickdesaulniers
Copy link

If I add -I. (from @juj ), compilation fails because zlib.hL34 tries to include zconf.h.

@nickdesaulniers
Copy link

If I simply curl zconf.h into the dir, building proceeds. PR inbound.

nickdesaulniers pushed a commit to nickdesaulniers/BananaBread that referenced this issue Sep 8, 2014
@nickdesaulniers
Copy link

Unfortunately, looks like we can't use crunch on OSX. @juj seems to already have run into this one...

@juj
Copy link
Author

juj commented Sep 8, 2014

You can install crunch via Emscripten SDK on OSX (type ./emsdk install crunch-1.04). I hacked together a build from the patches that were provided in that issue, and packaged the resulting build up to emsdk.

@nickdesaulniers
Copy link

@juj , can I install crunch given emscripten's source, instead of having to install the sdk?

kripken added a commit that referenced this issue Sep 11, 2014
add zconf.h header for OSX builds Fixes #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants