plugin/req-resp-modifier in an endpoint is not called if one of the backend CEL evaluations fails #542
Comments
|
the bug is upstream opened luraproject/lura#597 |
|
This issue is marked as stale because it has been open over 90 days with no activity. Remove the stale label or comment or this will be closed in 15 days. |
|
This issue was closed because it has been marked as stalled for 15 days with no activity. |
|
This issue was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Environment info:
Describe the bug
plugin/req-resp-modifier in an endpoint is not called if one of the backend CEL evaluations fails
Your configuration file:
{ "$schema": "https://www.krakend.io/schema/v3.json", "version": 3, "name": "conditional test", "timeout": "3000s", "cache_ttl": "300s", "output_encoding": "json", "disable_rest": false, "plugin": { "folder": "./plugins/", "pattern": ".so" }, "extra_config": { "telemetry/logging": { "level": "DEBUG", "prefix": "[KRAKEND]", "syslog": false, "stdout": true } }, "endpoints": [ { "endpoint": "/services", "input_headers": [ "X-Group-Id" ], "method": "GET", "output_encoding": "json-collection", "extra_config": { "plugin/req-resp-modifier": { "name": [ "krakend-response-aggregator" ] } }, "backend": [ { "group": "app1", "url_pattern": "/pattern1", "encoding": "safejson", "sd": "static", "method": "GET", "host": [ "localhost:8090" ], "extra_config": { "validation/cel": [ { "check_expr": "'group1' in req_headers['X-Group-Id']" } ] } }, { "group": "app2", "url_pattern": "/pattern1", "encoding": "safejson", "sd": "static", "method": "GET", "host": [ "localhost:8090" ], "extra_config": { "validation/cel": [ { "check_expr": "'group2' in req_headers['X-Group-Id']" } ] } }, { "group": "app3", "url_pattern": "/pattern2", "encoding": "safejson", "sd": "static", "method": "GET", "host": [ "localhost:8090" ], "extra_config": { "validation/cel": [ { "check_expr": "'group1' in req_headers['X-Group-Id']" } ] } } ] } ] }Configuration check output:
Result of
krakend check -dtc krakend_conditional.json --lintcommandCommands used:
How did you start the software?
Expected behavior
The objective is to call multiple backends on a endpoint conditionally and return each backend response as a JSON collection where each element is the backend response.
Each backend is called if an HTTP header values matches a condition.
Each backend has a group defined and I have written a response modifier plugin that applied to the endpoint gets the merged response and then collapses each group response and moves the group key name to the value of
"name"into the each backend response and adds the response collection to a"collection"object.So each backend returns something in the likes of
{ "groupId": "group1", "url": "/pattern1" }Merged response would look like
{ "app1": { "groupId": "group1", "url": "/pattern1" }, "app3": { "groupId": "group1", "url": "/pattern2" } }And modified response by the custom plugin:
{ "collection": [ { "name": "app1", "groupId": "group1", "url": "/pattern1" }, { "name": "app3", "groupId": "group1", "url": "/pattern2" } ] }With
output_encodingasjson-collectionwe would get:[ { "name": "app1", "groupId": "group1", "url": "/pattern1" }, { "name": "app3", "groupId": "group1", "url": "/pattern2" } ]Call to
servicesendpoint should return the expected collection resulting of the custom plugin response modification but instead returns an empty JSON collectionSetting the endpoint's
output_encodingtojsonshows that the backend responses were merged but the response modifier was not triggered.{ "app1": { "groupId": "group1", "url": "/pattern1" }, "app3": { "groupId": "group1", "url": "/pattern2" } }Logs:
The custom-plugin has logging and it should be visible with debug
Additional comments:
Changing the CEL expression with group2 to group1 so that all backends pass the CEL evaluation proves that the custom plugin works when called
Logs
The text was updated successfully, but these errors were encountered: