Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window scaling not accurate in software mode #531

Open
Cooler-1 opened this issue Nov 15, 2024 · 8 comments
Open

Window scaling not accurate in software mode #531

Cooler-1 opened this issue Nov 15, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@Cooler-1
Copy link

Windowed mode does not scale properly in software mode. The window stays at 640x480, whereas in OpenGL mode it properly adjusts the size to 320x200, 320x240, 640x400, etc.

@Pedro-Beirao
Copy link
Collaborator

It scales properly for me in both software and opengl. Tested in Windows and MacOS.
What OS are you using? And please attach a video of this issue

@Cooler-1
Copy link
Author

Windows 10

2024-11-18.13-46-45.mp4

@KernelLeak
Copy link

Would I be correct in saying that it's not so much the image not scaling properly, but the window changing it's size along with the resolution in OpenGL mode, but staying pretty much the same in software mode?

@Pedro-Beirao
Copy link
Collaborator

Ok I was wrong, I can reproduce. Thanks for the report.
The window size changes, but it doenst change to the correct selected size.

I had tested it with big changes (like 1080p -> 200p), so it seemed fine at first glance

For example
200p -> 400p makes the windows slightly bigger, but not double the size

@Pedro-Beirao Pedro-Beirao added the bug Something isn't working label Nov 20, 2024
@Pedro-Beirao
Copy link
Collaborator

Looking into the code, software is "correct". In order to not make a tiny (almost unusable) 200p window, it scales it to atleast 480p.
coelckers/prboom-plus@3a578e6

Note that you can still resize the window with your mouse to make it smaller.

I'll change OpenGL to do the same. Thanks for the report!

@Cooler-1
Copy link
Author

Cooler-1 commented Dec 5, 2024

I use Magpie to scale for CRT emulation and the window not being pixel accurate breaks it.

@Pedro-Beirao
Copy link
Collaborator

I use Magpie to scale for CRT emulation and the window not being pixel accurate breaks it.

Thats an interesting use case. @rfomin, seems like a good reason to allow initial window size of 200p. Shall I change this?

@rfomin
Copy link
Collaborator

rfomin commented Dec 6, 2024

I use Magpie to scale for CRT emulation and the window not being pixel accurate breaks it.

Thats an interesting use case. @rfomin, seems like a good reason to allow initial window size of 200p. Shall I change this?

Sure, I'm not against it.

Magpie seems good. We should probably add CRT emulation shaders at some point.

@Pedro-Beirao Pedro-Beirao reopened this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants