Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPL does not handle pitch bends in MIDIs #472

Closed
unithecutie opened this issue Jan 13, 2024 · 2 comments
Closed

OPL does not handle pitch bends in MIDIs #472

unithecutie opened this issue Jan 13, 2024 · 2 comments

Comments

@unithecutie
Copy link

unithecutie commented Jan 13, 2024

OPL ignores pitch bends in MIDIs completely and makes them sound very odd: Here's an example with "Workout" by Korp.

https://www.youtube.com/watch?v=mxh3UhRyi3s

The charango lead in the MIDI pitch bends a lot; here's an example with Roland GM.
(converted to MP4 so I can send it here)

charango.mp4
@rfomin
Copy link
Collaborator

rfomin commented Jan 13, 2024

OPL ignores pitch bends in MIDIs completely and makes them sound very odd: Here's an example with "Workout" by Korp.

Does it work in Chocolate/Crispy Doom?

Maybe it is supposed to work that way: Only the MSB of the pitch bend value is considered: this is what Doom does. https://github.com/chocolate-doom/chocolate-doom/blob/72d9e9318c4ccc61dab29bb9cc30bc8a9a93266d/src/i_oplmusic.c#L1231-L1232

Also please provide more info, which Fredoom version, which level etc.

@unithecutie
Copy link
Author

Oh, then it's supposed to work that way.
It's one of the later autobuilds.

@unithecutie unithecutie closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants