Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Raven MIDI pack for Heretic #463

Closed
mooreye opened this issue Dec 19, 2023 · 3 comments
Closed

Support Raven MIDI pack for Heretic #463

mooreye opened this issue Dec 19, 2023 · 3 comments

Comments

@mooreye
Copy link

mooreye commented Dec 19, 2023

https://www.doomworld.com/forum/topic/114080-raven-midi-pack-project-complete/

Crispy-Heretic supports this MIDI pack, it would be great if DSDA-Doom did too.

@kraflab
Copy link
Owner

kraflab commented Dec 19, 2023

What doesn't work exactly? Dsda-doom has musinfo support as well.

@mooreye
Copy link
Author

mooreye commented Dec 19, 2023

I loaded this as a -file after -iwad heretic.wad. There should be a different music track in E3M1 than in E1M1 (this midi pack replaces duplicates), but I can hear that they are the same.

Here someone mentions this doesn't work too: https://www.doomworld.com/forum/topic/114080-raven-midi-pack-project-complete/?page=7&tab=comments#comment-2596537

Doom Wiki has something to say about this too: https://doomwiki.org/wiki/Raven_MIDI_Pack

Although technically vanilla-compatible in that all tracks can be converted to MUS format and used in Heretic levels, the tracks from the pack will only be heard if played in a port that can read the [EMAPINFO or ZMAPINFO](https://doomwiki.org/wiki/MAPINFO) lumps, or otherwise allows to map Heretic map slots to the corresponding MUS_ExMy lump if present, such as [Crispy Heretic](https://doomwiki.org/wiki/Crispy_Doom). This is because instead of having duplicated music lumps (like how registered Doom has D_E1M7, D_E2M5, and D_E3M5 all containing the same track), Heretic reuses the same lump (like the fourth episode of Ultimate Doom reuses tracks associated with levels from the first three episodes). Since this behavior is hardcoded, there is no way around this, short of splitting the pack into several episode-specific replacements.

Does this mean DSDA-Doom doesn't support these lumps?

@kraflab
Copy link
Owner

kraflab commented Dec 19, 2023

No, the problem was musinfo default track support. Fixed here: 32358cb

@kraflab kraflab closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants