Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transports/quic: Refactor listener handling (updated) #19

Merged
merged 32 commits into from
Aug 27, 2022

Commits on Jun 24, 2022

  1. core/muxing: Replace Into<io::Error> bound on StreamMuxer with `s…

    …td::error::Error` (libp2p#2710)
    
    * core/muxing: Remove `Into<io::Error>` bound from `StreamMuxer::Error`
    
    This allows us to preserve the type information of a muxer's concrete
    error as long as possible. For `StreamMuxerBox`, we leverage `io::Error`'s
    capability of wrapping any error that implements `Into<Box<dyn Error>>`.
    
    * Use `?` in `Connection::poll`
    
    * Use `?` in `muxing::boxed::Wrap`
    
    * Use `futures::ready!` in `muxing::boxed::Wrap`
    
    * Fill PR number into changelog
    
    * Put `Error + Send + Sync` bounds directly on `StreamMuxer::Error`
    
    * Move `Send + Sync` bounds to higher layers
    
    * Use `map_inbound_stream` helper
    
    * Update changelog to match new implementation
    thomaseizinger authored Jun 24, 2022
    Configuration menu
    Copy the full SHA
    0f40e51 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. protocols/identify: Extend log message on second identify push (libp2…

    …p#2726)
    
    Print remote peer ID when seeing a second identify push stream coming in.
    mxinden authored Jun 26, 2022
    Configuration menu
    Copy the full SHA
    2c70c59 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    072d736 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Configuration menu
    Copy the full SHA
    40744be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f814b21 View commit details
    Browse the repository at this point in the history
  3. transports/tcp/: Call take_error on tokio TcpStream (libp2p#2725)

    See e04e95a for the rational.
    
    With tokio `v1.19.0` released, `TcStream` exposes `take_error`.
    
    This commit applies the same fix from e04e95a to the tokio TCP provider.
    mxinden authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    7190952 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. build(deps): Bump styfle/cancel-workflow-action from 0.9.1 to 0.10.0 (l…

    …ibp2p#2731)
    
    Bumps [styfle/cancel-workflow-action](https://github.com/styfle/cancel-workflow-action) from 0.9.1 to 0.10.0.
    - [Release notes](https://github.com/styfle/cancel-workflow-action/releases)
    - [Commits](styfle/cancel-workflow-action@a40b884...bb6001c)
    
    ---
    updated-dependencies:
    - dependency-name: styfle/cancel-workflow-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Jun 28, 2022
    Configuration menu
    Copy the full SHA
    9f7d0fe View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Configuration menu
    Copy the full SHA
    423adca View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. protocols/gossipsub: Fix a typo in error message (libp2p#2739)

    * protocols/gossipsub: Fix a typo in error message
    
    * protocols/gossipsub: Make the error message accurately
    ackintosh authored Jun 30, 2022
    Configuration menu
    Copy the full SHA
    748588e View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Configuration menu
    Copy the full SHA
    862ae14 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31f1d66 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2022

  1. protocols/gossipsub/: Allow custom protocol id (libp2p#2718)

    Allow for custom protocol ID via `GossipsubConfigBuilder::protocol_id()`.
    bernardoaraujor authored Jul 2, 2022
    Configuration menu
    Copy the full SHA
    6db5712 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. protocols/identify: Fix race condition in discover_peer_after_disconn…

    …ect (libp2p#2744)
    
    **Summary** of the plot of the `discover_peer_after_disconnect` test:
    
    1. `swarm2` connects to `swarm1`.
    2. `swarm2` requests an identify response from `swarm1`.
    3. `swarm1` sends the response to `swarm2`.
    4. `swarm2` disconnects from `swarm1`.
    5. `swarm2` tries to disconnect.
    
    **Problem**
    
    `libp2p-identify` sets `KeepAlive::No` when it identified the remote. Thus `swarm1` might
    identify` `swarm2` before `swarm2` identified `swarm1`. `swarm1` then sets `KeepAlive::No` and thus closes the
    connection to `swarm2` before `swarm2` identified `swarm1`. In such case the unit test
    `discover_peer_after_disconnect hangs indefinitely.
    
    **Solution**
    
    Add an initial delay to `swarm1` requesting an identification from `swarm2`, thus ensuring `swarm2`
    is always able to identify `swarm1`.
    mxinden authored Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b28cdb3 View commit details
    Browse the repository at this point in the history
  2. core/src/transport: Poll Transport directly, remove Transport::Listen…

    …er (libp2p#2652)
    
    Remove the concept of individual `Transport::Listener` streams from `Transport`.
    Instead the `Transport` is polled directly via `Transport::poll`. The
    `Transport` is now responsible for driving its listeners.
    elenaf9 authored Jul 4, 2022
    Configuration menu
    Copy the full SHA
    62622a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Configuration menu
    Copy the full SHA
    7df6bae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f2b7cb View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Configuration menu
    Copy the full SHA
    d0da3a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2022

  1. Configuration menu
    Copy the full SHA
    6b758e3 View commit details
    Browse the repository at this point in the history
  2. transports/quic: adapt to transport trait changes

    Adapt to the transport changes of libp2p#2652.
    Note: this is only a draft "to make it work", and not a proper
    implementation. It does not support listening on multiple addresses.
    The listening logic with multiple Endpoints will need to be supported for
    the upstream implementation.
    elenaf9 committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    5157ea1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    57743ef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e5e5b34 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    39d855c View commit details
    Browse the repository at this point in the history
  6. transports/quic: use intra-doc links in docs

    Co-authored-by: Max Inden <[email protected]>
    elenaf9 and mxinden committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    0e797cf View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ef7b823 View commit details
    Browse the repository at this point in the history
  8. transports/quic: fix clippy

    elenaf9 committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    a375524 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    917bccc View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Configuration menu
    Copy the full SHA
    5fe3e1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    574d534 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. cargo fmt

    kpp committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    9e1cc81 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #5 from kpp/kpp-multiple-endpoints

    Review fixes
    elenaf9 authored Jul 22, 2022
    Configuration menu
    Copy the full SHA
    2c41f70 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2022

  1. Configuration menu
    Copy the full SHA
    1a4b8ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf06d96 View commit details
    Browse the repository at this point in the history