Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can ejc-sql support sql.el's sql-interactive-mode? #116

Open
stardiviner opened this issue Dec 25, 2019 · 3 comments
Open

Can ejc-sql support sql.el's sql-interactive-mode? #116

stardiviner opened this issue Dec 25, 2019 · 3 comments
Labels

Comments

@stardiviner
Copy link
Contributor

Is ejc-sql possible to provide code complete for sql.el's sql-interactive-mode buffer?

@stardiviner
Copy link
Contributor Author

Here is my temporary solution:

(defun ejc-sql-interactive-mode-setup ()
  "Setup ejc-sql completion in `sql-interactive-mode'."
  (interactive)
  (call-interactively 'ejc-connect)
  (ejc-sql-mode)
  (auto-complete-mode 1)
  (ejc-ac-setup))
(add-hook 'sql-interactive-mode #'ejc-sql-interactive-mode-setup)

WDYT?

@kostafey
Copy link
Owner

kostafey commented Feb 2, 2020

@stardiviner, how do you plan to connect to the desired database? Are you going to use sql-mode connection engine? Maybe this ad-hoc workaround will be ok for you. But for future development, I think it's worth to provide ejs-sql own DB connection for sql-interactive-mode.

@kostafey kostafey added the task label Feb 2, 2020
@stardiviner
Copy link
Contributor Author

I agree, thanks that this is on the ejc-sql planning list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants