-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with Rails4 #8
Comments
@eqmx I'm testing a Rails4 branch as we speak. Comments from you would be helpful, and then we can pull back to @konung https://github.com/kastman/comfy_imprint/tree/rails4 You can use this branch by listing comfy-imprint in your gemfile like:
|
I added following in gem file and did bundle update/bundle install it worked fine. when I do migrations "comfy_imprint:install:migrations" I get following error I tried setting up path export PATH=$PATH:/usr/local/git/bin/ but still getting same error. Sorry, I am new to rails! I appreciate your help Kastman! |
You're almost there - that's a rake command like the migration right below it:
I updated it in the readme in my repo. Goood luck! |
Thanks that worked; however, copied "mount ComfyImprint::Engine, at: "/contact-us"" to routes.rb, |
Hmm, sounds like you're doing everything right. Can you send the output of
and at the bottom you should see something like:
I doubt it, but maybe there's a typo in your route? Or it could possibly have to do with the order of the routes? I have mine at the very top of routes.rb, above root and comfy_route and verified that it's working for me with 'localhost:3000/contact-us' It's been a while since I did focused Rails work so I'm sorry if my help are just guesses at this point! |
Thanks for the quick reply, I am now able to see contact-us form. |
Glad it's working for you. You can do basic customization in However, this is often not enough. Luckily, comfy_imprint is a rails engine and you can override any of the views (well, there are only two, new and thank_you). Practically, this involves adding erb or haml files in the main app's tree that mirrors the layout of the engine. So, you'd want to add an overriding view in Hope that helps, |
Ouuuch! To quote my fav character.... Mmmmm This is embarrassing guys, apparently all of notifications from this conversation were going into SPAM folder. I just noticed 5 stars on the projects. Really sorry. Anyways I haven't done any CMS works since I setup this gem, so I didn't try this with CMS & Rails 4. I'll gladly pull in any requests if you choose too send me one, and will push updated gem to rubygems.org. |
Hey Nick, I haven't made any changes since January, but it's also been working in a very low-traffic production site since then without any problems. I don't even remember what I was waiting for for the PR, but I'll send one now. Feel free to comment and I'll make any fixes you think are appropriate - really the only concern would be possibly changing some of the dependencies within the engine (I think simpleform 2->3, if I recall?) Take a look and see what you think. Best, |
If would be great if it can work with new CMS that is in Rails4.
Thanks!
The text was updated successfully, but these errors were encountered: