From 87a642d513130a2b110341bf61dd43b6d0e0293c Mon Sep 17 00:00:00 2001 From: Luiz Carvalho Date: Mon, 5 Aug 2024 15:32:33 -0400 Subject: [PATCH] Fix default value in verify-signed-rpms The value of the `FAIL_UNSIGNED` parameter of the `verify-signed-rpms` Task is used when calling the `rpm_verifier` binary. An empty string value is not a valid value result in this error: ``` Usage: rpm_verifier [OPTIONS] Try 'rpm_verifier --help' for help. Error: Invalid value for '--fail-unsigned': '' is not a valid boolean. ``` This commit changes the default value to `"false"`. This is both valid and inline with [ADR-14](https://konflux-ci.dev/architecture/ADR/0014-let-pipelines-proceed.html). Signed-off-by: Luiz Carvalho --- task/verify-signed-rpms/0.1/verify-signed-rpms.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/task/verify-signed-rpms/0.1/verify-signed-rpms.yaml b/task/verify-signed-rpms/0.1/verify-signed-rpms.yaml index 4b976866d2..0d9522401e 100644 --- a/task/verify-signed-rpms/0.1/verify-signed-rpms.yaml +++ b/task/verify-signed-rpms/0.1/verify-signed-rpms.yaml @@ -11,7 +11,7 @@ spec: - name: FAIL_UNSIGNED type: string description: "[true | false] If true fail if unsigned RPMs were found" - default: "" + default: "false" - name: WORKDIR type: string default: /tmp