Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: SSH2 upgraded to 1.4.0 was breaking #22

Closed
kolban-google opened this issue Dec 17, 2021 · 1 comment
Closed

Breaking change: SSH2 upgraded to 1.4.0 was breaking #22

kolban-google opened this issue Dec 17, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kolban-google
Copy link
Owner

A forced upgrade of dependencies by GitHub caused a breaking change. Examining now. Issue is that we now get errors that look like:

(node:19468) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'EOF' of undefined
    at SFTP.<anonymous> (/home/kolban/projects/sftp-gcs/sftp-gcs.js:663:69)
    at SFTP.emit (events.js:400:28)
    at 12 (/home/kolban/projects/sftp-gcs/node_modules/ssh2/lib/protocol/SFTP.js:3115:15)
    at SFTP.push (/home/kolban/projects/sftp-gcs/node_modules/ssh2/lib/protocol/SFTP.js:278:11)
    at CHANNEL_DATA (/home/kolban/projects/sftp-gcs/node_modules/ssh2/lib/server.js:750:23)
    at 94 (/home/kolban/projects/sftp-gcs/node_modules/ssh2/lib/protocol/handlers.misc.js:859:16)
    at Protocol.onPayload (/home/kolban/projects/sftp-gcs/node_modules/ssh2/lib/protocol/Protocol.js:2025:10)
    at AESGCMDecipherBinding.decrypt (/home/kolban/projects/sftp-gcs/node_modules/ssh2/lib/protocol/crypto.js:1086:26)
    at Protocol.parsePacket [as _parse] (/home/kolban/projects/sftp-gcs/node_modules/ssh2/lib/protocol/Protocol.js:1994:25)
    at Protocol.parse (/home/kolban/projects/sftp-gcs/node_modules/ssh2/lib/protocol/Protocol.js:293:16)
@kolban-google kolban-google added the bug Something isn't working label Dec 17, 2021
@kolban-google kolban-google self-assigned this Dec 17, 2021
@kolban-google
Copy link
Owner Author

There was a breaking change from pre 1.0.0 of SSH2 to the latest. This was documented here:

mscdex/ssh2#935

Thankfully, the fix was easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant