Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change multiplicative generator of bn254 to 5 instead of 7 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbaylina
Copy link

In the field Fr of the curve bn254 the lowest generator is 5 instead of 7.

This is the standard used in other libraries.

See:

This PR breaks backwards compatibility, but I believe it's important to fix it ASAP so we use 5 for the new circuits.

Copy link
Owner

@kobigurk kobigurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I agree that it's best the whole community works with one generator.

@ytrezq
Copy link

ytrezq commented Sep 4, 2024

@jbaylina : beginner question : why is it important for the value to be the same as other libraries ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants