Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two push events are triggered #61

Open
jfroche opened this issue Feb 20, 2023 · 1 comment
Open

Two push events are triggered #61

jfroche opened this issue Feb 20, 2023 · 1 comment

Comments

@jfroche
Copy link
Contributor

jfroche commented Feb 20, 2023

Whenever niv-updater-action needs to create a new branch, it triggers two different push events, one for the branch creation, another for the commit containing the actual niv dependencies update.
We are using github actions on our repositories. Having two events means github actions are triggered once for the branch (copy of the base branch) and a second time for the commit. We tried to use concurency to cancel the first run but it randomly cancel the right one.

Would it be an option to use the git client to push the created the branch and the commit at once ?

@knl
Copy link
Owner

knl commented Feb 21, 2023

Hi @jfroche thanks for reporting this issue. I think I initially implemented it this way to that one doesn't have to have a checkout of the code. I'll try to implement it over the weekend by either using the API to achieve the same, or have an option to use git executable (if one already has checked out the code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants