Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

How to sync-up with the latest manifest of knative in a timely fashion #276

Open
houshengbo opened this issue Jan 29, 2020 · 3 comments
Open

Comments

@houshengbo
Copy link

houshengbo commented Jan 29, 2020

Problem
This issue applies to eventing-operator as well. If knative has experienced some significant changes, which can lead to key resource deletion, but it has not released this version yet, how can operator catch the latest change and implement based this change in time?

For example, eventing dropped sources-controller knative/eventing#2448, we know we need to add logic removing the sources-controller deployment in the reconcile loop, but how can we pull the latest manifest and test with operator code? I do not think we should wait until the next version is released for operator development and test.

Persona:
Developers

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

@aliok
Copy link
Member

aliok commented Feb 4, 2020

but how can we pull the latest manifest and test with operator code

We need some CI magic to have nightly releases then?

@houshengbo
Copy link
Author

knative/eventing-operator#108
This PR can be used as reference. We can create a similar one, pulling the nightly release can pushing as a new PR for review. We can run it every day or week.

@aliok
Copy link
Member

aliok commented Mar 2, 2020

This PR can be used as reference. We can create a similar one, pulling the nightly release can pushing as a new PR for review. We can run it every day or week.

+1 on this one.
I can work on this.

@mattmoor how is the setup for PRs like knative/eventing-operator#108 ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants