Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

support to tweak resource limits and requests for knative deployments #161

Closed
nak3 opened this issue Sep 6, 2019 · 1 comment · Fixed by #362
Closed

support to tweak resource limits and requests for knative deployments #161

nak3 opened this issue Sep 6, 2019 · 1 comment · Fixed by #362

Comments

@nak3
Copy link
Contributor

nak3 commented Sep 6, 2019

limits and requests are defined like https://github.com/knative/serving-operator/blob/master/cmd/manager/kodata/knative-serving/0.8.0.yaml#L752-L758, but they are not configurable.

E.g - If we changed resources.limits by kubectl edit deployment autoscaler -n knative-serving, it is reverted with same reason of #160.
@aliok
Copy link
Member

aliok commented Feb 15, 2020

One way of supporting this would be #277

@Fabian-K Fabian-K mentioned this issue Feb 18, 2020
Open
@jcrossley3 jcrossley3 mentioned this issue Mar 14, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resources override jcrossley3/serving-operator
2 participants
@aliok @nak3