-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend secret reading for webhook certificates #2303
Comments
This issue is stale because it has been open for 90 days with no |
/reopen |
@skonto: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue is stale because it has been open for 90 days with no |
Webhook Certificates reconciler's logic will update secrets contents if the secret is expired or if the secret is empty.
We start with an empty secret so the reconciler can generate its contents. This is an internal process. There is a hardcoded value for renewal (1 day).
However there are two candidate use cases we may want to consider extending this logic for:
a) users operate their infra with specific certificates for all their stuff. Examples:
b) developers may want to use this repo for generic webhook development
This relates to: #1972 but that ticket is focused beyond secrets and here the goal is to add support for using a secret that already contains a certificate and it is externally managed. There are some options wrt to what flexibility to provide (assuming the reconciler is not removed from the picture):
a) Some validation could happen at the reconciler side as it is now eg. expiration logic to warn users.
b) User provides a CA bundle and the reconciler creates the rest of the keys.
c) User provides all certificates CA/TLS keys and so the reconciler can be used for validation.
Older slack discussion on this topic here.
/kind feature
The text was updated successfully, but these errors were encountered: