Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Istio version tested/supported in release notes #958

Open
AngeloDanducci opened this issue Jul 26, 2022 · 18 comments
Open

Include Istio version tested/supported in release notes #958

AngeloDanducci opened this issue Jul 26, 2022 · 18 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/enhancement lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@AngeloDanducci
Copy link
Contributor

Had someone in Slack ask about supported Istio versions today but our documentation was out of date.

After talking with Dave I think it makes sense to make the docs point directly to the releases page and then include what version of Istio we are supporting/testing in future releases.

@dprotaso
Copy link
Contributor

Any chance we can update the last few releases to mention the version- ie. releases 1.3 to 1.6 are currently in our support window

@AngeloDanducci
Copy link
Contributor Author

I can go back and update the old releases manually in the meantime 👍

@nak3
Copy link
Contributor

nak3 commented Jul 27, 2022

+1

FYI net-gateway-api adds the release page by this script -https://github.com/knative-sandbox/net-gateway-api/blob/main/hack/release.sh#L69 .
Here is the result https://github.com/knative-sandbox/net-gateway-api/releases

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2022
@dprotaso
Copy link
Contributor

/lifecycle frozen

@knative-prow knative-prow bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 26, 2022
@ReToCode
Copy link
Member

Is there still work to be done here? net-istio does automatically create release notes and we added a link from the docs.
@nak3 , @dprotaso?

@dprotaso
Copy link
Contributor

Looks like we made the necessary changes to the website: https://knative.dev/docs/install/installing-istio/#supported-istio-versions

But the latest release doesn't mention the Istio version - https://github.com/knative-sandbox/net-istio/releases

Our release note automation [1][2] will scan PR bodies for release-note blocks and surface those. It still requires a release lead to update the release with these generated notes (hopefully this will be automated (knative/test-infra#3655))

But if the person bumping Istio in a PR didn't include this message (or there was no bump) it's not going to show up.

We could do what @nak3 suggested and create a 'header' for the release note - that's probably the actionable thing for this issue

[1] https://github.com/kubernetes/release/tree/master/cmd/release-notes
[2] https://github.com/knative/actions/blob/main/.github/workflows/release-notes.yaml)

@dprotaso
Copy link
Contributor

I just updated the 1.9 release note with Tested with Istio 1.16.0

@ReToCode ReToCode added kind/good-first-issue Denotes an issue ready for a new contributor. kind/enhancement labels Feb 16, 2023
@Nageshbansal
Copy link

Hello @ReToCode @dprotaso, I noticed this issue and would love to contribute. Is it still open for someone to work on?

@ReToCode
Copy link
Member

👍 Sure, feel free to assign it to yourself and start working on a PR.

@Nageshbansal
Copy link

Sure. And, the current issue is to update the release by adding generated notes and including headers for istio version. Is that correct?

@ReToCode
Copy link
Member

Yes: #958 (comment)

We could do what @nak3 suggested and create a 'header' for the release note - that's probably the actionable thing for this issue

@Nageshbansal
Copy link

/assign

@dprotaso
Copy link
Contributor

dprotaso commented Jun 2, 2023

@Nageshbansal are you still interested in working on this issue?

@dprotaso dprotaso removed the kind/good-first-issue Denotes an issue ready for a new contributor. label Jun 2, 2023
@dprotaso
Copy link
Contributor

dprotaso commented Jun 2, 2023

/good-first-issue

@knative-prow
Copy link

knative-prow bot commented Jun 2, 2023

@dprotaso:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 2, 2023
@Nageshbansal
Copy link

@dprotaso , yes, I'll make the PR soon. Thanks

@thesuperzapper
Copy link

@dprotaso @ReToCode This is a very important usability issue, right now there is no way to know which versions of Istio are "officially supported" by what version of Knative.

The only way to know for sure is to test yourself, and issues might not expose themselves until after you have deployed to production.

I would be grateful for a list of Istio versions that each release ran its integration tests on, as this would probably be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/enhancement lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

6 participants