-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Istio version tested/supported in release notes #958
Comments
Any chance we can update the last few releases to mention the version- ie. releases 1.3 to 1.6 are currently in our support window |
I can go back and update the old releases manually in the meantime 👍 |
+1 FYI net-gateway-api adds the release page by this script -https://github.com/knative-sandbox/net-gateway-api/blob/main/hack/release.sh#L69 . |
This issue is stale because it has been open for 90 days with no |
/lifecycle frozen |
Looks like we made the necessary changes to the website: https://knative.dev/docs/install/installing-istio/#supported-istio-versions But the latest release doesn't mention the Istio version - https://github.com/knative-sandbox/net-istio/releases Our release note automation [1][2] will scan PR bodies for But if the person bumping Istio in a PR didn't include this message (or there was no bump) it's not going to show up. We could do what @nak3 suggested and create a 'header' for the release note - that's probably the actionable thing for this issue [1] https://github.com/kubernetes/release/tree/master/cmd/release-notes |
I just updated the 1.9 release note with |
👍 Sure, feel free to assign it to yourself and start working on a PR. |
Sure. And, the current issue is to update the release by adding generated notes and including headers for istio version. Is that correct? |
Yes: #958 (comment)
|
/assign |
@Nageshbansal are you still interested in working on this issue? |
/good-first-issue |
@dprotaso: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dprotaso , yes, I'll make the PR soon. Thanks |
@dprotaso @ReToCode This is a very important usability issue, right now there is no way to know which versions of Istio are "officially supported" by what version of Knative. The only way to know for sure is to test yourself, and issues might not expose themselves until after you have deployed to production. I would be grateful for a list of Istio versions that each release ran its integration tests on, as this would probably be sufficient. |
Had someone in Slack ask about supported Istio versions today but our documentation was out of date.
After talking with Dave I think it makes sense to make the docs point directly to the releases page and then include what version of Istio we are supporting/testing in future releases.
The text was updated successfully, but these errors were encountered: