Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Status LED for diagnostics of device #25

Open
klew opened this issue Feb 17, 2020 · 2 comments
Open

Add Status LED for diagnostics of device #25

klew opened this issue Feb 17, 2020 · 2 comments

Comments

@klew
Copy link
Owner

klew commented Feb 17, 2020

No description provided.

@ermaya
Copy link

ermaya commented Feb 17, 2020

SuplaDevice.cpp

you should add something here because now when the network is disconnected the status remains "17" Registered and ready.

1046 if (!Supla::Network::IsReady()) {
1047 wait_for_iterate = millis() + 500;
1048 return;

for example:

1046 if (!Supla::Network::IsReady()) {
1047 wait_for_iterate = millis() + 500;
1048 status(STATUS_DISCONNECTED, "Not connected to Network");
1049 return;

@klew
Copy link
Owner Author

klew commented Mar 3, 2020

I added new status. You can check it.
On my side this problem was not visible, because it always changed status to "STATUS_DISCONNECTED" before "IsReady" method returned "false". In fact it always took few seconds before this method started to return false, so it always executed those lines first:
if (!Supla::Network::Connected()) {
status(STATUS_DISCONNECTED, "Not connected");

Here is the change: 35f26f0

klew pushed a commit that referenced this issue Jan 9, 2021
RGB, RGBW, VirtualBinary added to new framework. Some bug fixes and improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants