Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epic: refacto the Message struct #159

Open
9 tasks
ClementWalter opened this issue Nov 28, 2024 · 0 comments
Open
9 tasks

epic: refacto the Message struct #159

ClementWalter opened this issue Nov 28, 2024 · 0 comments

Comments

@ClementWalter
Copy link
Member

ClementWalter commented Nov 28, 2024

Why

The current message differs from the reference EELS one.

    struct Message {
        bytecode: felt*,
        bytecode_len: felt,
        valid_jumpdests_start: DictAccess*,
        valid_jumpdests: DictAccess*,
        calldata: felt*,
        calldata_len: felt,
        value: Uint256*,
        caller: felt,
        parent: Parent*,
        address: felt,
        code_address: felt,
        read_only: felt,
        is_create: felt,
        depth: felt,
        env: Environment*,
        cairo_precompile_called: felt,
    }
@dataclass
class Message:
    """
    Items that are used by contract creation or message call.
    """

    caller: Address
    target: Union[Bytes0, Address]
    current_target: Address
    gas: Uint
    value: U256
    data: Bytes
    code_address: Optional[Address]
    code: Bytes
    depth: Uint
    should_transfer_value: bool
    is_static: bool
    accessed_addresses: Set[Address]
    accessed_storage_keys: Set[Tuple[Address, Bytes32]]
    parent_evm: Optional["Evm"]
  1. Keeping the same structs with the same naming ease the dev
  2. we miss the accessed addresses and storage_keys slots (we used the reference data from starknet in kakarot);

What

Tasks

@github-project-automation github-project-automation bot moved this to Backlog in Keth Nov 28, 2024
@ClementWalter ClementWalter added this to the EF tests no state root milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant