Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port kiwix-tools to docoptcpp #691

Closed
mgautierfr opened this issue Aug 22, 2024 · 2 comments
Closed

Port kiwix-tools to docoptcpp #691

mgautierfr opened this issue Aug 22, 2024 · 2 comments

Comments

@mgautierfr
Copy link
Member

Currently, kiwix-tools are using getopt to parse command line.

However, this library is a unix tool and is not available on Windows [1].
As other projects (zim-tools) are using docoptcpp and it is packaged by kiwix-build, it would be nice to use docoptcpp in kiwix-tools too.

This way, we would use only one dependency to parse command line and it would simplify the compilation on Windows.


[1] getopt is not really complex, it would be possible to compile it on Windows, but it means find the right upstream project, probably build a meson buildsystem (as Makefile is difficult on Windows) and integrate it in kiwix-build.

@kelson42
Copy link
Contributor

kelson42 commented Aug 31, 2024

@mgautierfr I guess you have implemented this feature with #695 and therefore this issue should be closed?

@mgautierfr
Copy link
Member Author

mgautierfr commented Sep 1, 2024

Yes it is. I don't know why it haven't been closed. We have a commit with a "fix ..."

It has to be in the PR description, not only for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants