Support range requests for video content #768

BPerlakiH · 2024-05-19T14:05:29Z

Fixes: #767

kelson42 · 2024-05-19T17:56:20Z

@BPerlakiH Codefactor should pass and I also see a few style problems.

….com:kiwix/apple into 767-support-range-requests-for-video-content

BPerlakiH · 2024-05-19T20:57:45Z

Please see it updated.

BPerlakiH · 2024-05-21T21:27:10Z

Model/Utilities/WebKitHandler.swift

-/// As a result of the large volume of small requests, CPU usage will be very high,
-/// which can result in app or webpage frozen.
-/// To mitigate, opting for the less "broken" behavior of ignoring Range header
-/// until WebKit behavior is changed.


I did found the root cause of this behaviour. In the original PR the byte range was one off, eg:

Byte-Range: 0-5 Content-Length: 5

Actually it should be either:

Byte-Range: 0-4 Content-Length: 5

OR

Byte-Range: 0-5 Content-Length: 6

Due to this one off error the browser was "kept" downloading the end of the range in chunks about ~8 bytes long.
Once the range was corrected, this side effect no longer exists.

Are you sure about this? I am still seeing the 8b range requests on this branch, with mp4 videos. webm videos did not trigger those small range requests…

Well... I did tested with mp4 files, and that is indeed triggering 8 bytes.
I also noticed that the "videojs" version is different on the ZIM file with mp4, than on the ZIM file with the webm test videos.
Maybe we will need an identical JS setup for both webm and mp4.

BPerlakiH · 2024-05-21T21:28:16Z

Model/Utilities/WebKitHandler.swift

                self?.sendHTTP404Response(urlSchemeTask, url: url)
                self?.stopFor(hash)
                return
            }
-            self?.sendHTTP200Response(urlSchemeTask, url: url, content: content)
+            if isVideo {
+                self?.sendHTTP206Response(urlSchemeTask, url: url, content: content, start: start, end: end)


we only apply the range responses to video type of contents

Only apply to but also Apply to ALL videos…

Support/injection.js

BPerlakiH · 2024-05-21T21:32:10Z

Model/Entities/Entities.swift

@@ -161,6 +177,11 @@ struct URLContent {
            return mime
        }
    }
+


This currently uses the ZIM file's modification date time to create the eTag, which I think a good enough solution for our purposes.

What is our purpose? Is this related to Range-requests?

My thinking here was, that I looked at what headers are returned in Safari / Caddy when webm is played.
So I wanted to have the very same ones, to make sure it works. One of them was this eTag, which can be generated based on the date the ZIM file was changed.
We can omit this if you think it is not needed.

No harm in keeping it IMO. ETag is supposed to be a uniq version ID for a resource and this implementation is OK in this regard since all resources are single-version made at the same time in a ZIM.
Still it feels like abusing the header to have the same for all resources 😀
Mandates a comment explaining this I think

rgaudin

Sorry about the long delay !! 😵‍💫

PR has no description while it introduces changes that seems unrelated to the linked ticket: all that date stuff, is it helping the range requests in anyway? Or is it just general improvements?

Otherwise Code looks OK but it doesn't seem to fix what it intends to: webm video did not trigger the many range request so I'm not looking for improvement there.
MP4 videos on the other hand was triggering the 8b requests… and still is with this branch

You are also returning 206 responses to all videos, regarding of whether a range-request was made. While mostly harmful, this is does not respect HTTP

rgaudin · 2024-05-23T16:28:09Z

Model/Entities/Entities.swift

@@ -161,6 +177,11 @@ struct URLContent {
            return mime
        }
    }
+


What is our purpose? Is this related to Range-requests?

rgaudin · 2024-05-23T16:59:46Z

Model/Utilities/Date+Extension.swift

+
+import Foundation
+
+extension Date {


Again, related to ranges or not?

This is related to the returned response header, eg. as on your screenshot, we have the Response:

Last-Modified: Thu, 16 May 2024 11:38:20 GMT

in order to have the date of the ZIM file formatted the same way, we need this change.
Again, if you think this is not needed, I can remove it.

No it's fine ; just wanted to make sure it was a side thing

rgaudin · 2024-05-23T17:44:27Z

Model/Utilities/WebKitHandler.swift

-/// As a result of the large volume of small requests, CPU usage will be very high,
-/// which can result in app or webpage frozen.
-/// To mitigate, opting for the less "broken" behavior of ignoring Range header
-/// until WebKit behavior is changed.


Are you sure about this? I am still seeing the 8b range requests on this branch, with mp4 videos. webm videos did not trigger those small range requests…

rgaudin · 2024-05-23T18:00:07Z

Model/Utilities/WebKitHandler.swift

                self?.sendHTTP404Response(urlSchemeTask, url: url)
                self?.stopFor(hash)
                return
            }
-            self?.sendHTTP200Response(urlSchemeTask, url: url, content: content)
+            if isVideo {
+                self?.sendHTTP206Response(urlSchemeTask, url: url, content: content, start: start, end: end)


Only apply to but also Apply to ALL videos…

kelson42 · 2024-06-01T16:13:15Z

Waiting that #784 is properly implemented to move forward.

kelson42 · 2024-06-06T19:42:47Z

ThisnPR shiukd be rebased and completed has nothing else is blocking.

BPerlakiH · 2024-08-02T06:40:55Z

Closing in favour of #894

BPerlakiH added 3 commits May 19, 2024 09:16

Fix missing handler case in Javascript

dd05ae8

Support range request for videos

4daca2c

Remove old comment

2f91bc6

BPerlakiH requested review from rgaudin and kelson42 May 19, 2024 14:05

BPerlakiH linked an issue May 19, 2024 that may be closed by this pull request

Support range requests for video content #767

Closed

BPerlakiH temporarily deployed to internal May 19, 2024 14:05 — with GitHub Actions Inactive

BPerlakiH changed the title ~~767 support range requests for video content~~ Support range requests for video content May 19, 2024

[CodeFactor] Apply fixes

198fcde

codefactor-io bot temporarily deployed to internal May 19, 2024 19:36 Inactive

BPerlakiH added 2 commits May 19, 2024 21:45

Fixlint

e361c5c

Merge branch '767-support-range-requests-for-video-content' of github…

3a8c676

….com:kiwix/apple into 767-support-range-requests-for-video-content

BPerlakiH temporarily deployed to internal May 19, 2024 19:45 — with GitHub Actions Inactive

Re-indent

fc50b16

BPerlakiH temporarily deployed to internal May 19, 2024 19:48 — with GitHub Actions Inactive

Merge branch 'main' into 767-support-range-requests-for-video-content

e53ad15

BPerlakiH temporarily deployed to internal May 20, 2024 21:51 — with GitHub Actions Inactive

BPerlakiH commented May 21, 2024

View reviewed changes

Support/injection.js Show resolved Hide resolved

BPerlakiH commented May 21, 2024

View reviewed changes

rgaudin requested changes May 23, 2024

View reviewed changes

kelson42 mentioned this pull request Jun 1, 2024

Impossible to seek on videos #215

Closed

kelson42 marked this pull request as draft June 2, 2024 03:18

kelson42 mentioned this pull request Jun 7, 2024

After resuming app (iOS) video displayed black #772

Closed

BPerlakiH closed this Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support range requests for video content #768

Support range requests for video content #768

BPerlakiH commented May 19, 2024

kelson42 commented May 19, 2024 •

edited

Loading

BPerlakiH commented May 19, 2024

BPerlakiH May 21, 2024

rgaudin May 23, 2024

BPerlakiH May 24, 2024 •

edited

Loading

BPerlakiH May 21, 2024

rgaudin May 23, 2024

BPerlakiH May 21, 2024 •

edited

Loading

rgaudin May 23, 2024

BPerlakiH May 23, 2024

rgaudin May 23, 2024

rgaudin left a comment

rgaudin May 23, 2024

rgaudin May 23, 2024

BPerlakiH May 23, 2024

rgaudin May 23, 2024

rgaudin May 23, 2024

rgaudin May 23, 2024

kelson42 commented Jun 1, 2024

kelson42 commented Jun 6, 2024

BPerlakiH commented Aug 2, 2024


		import Foundation

		extension Date {

Support range requests for video content #768

Support range requests for video content #768

Conversation

BPerlakiH commented May 19, 2024

kelson42 commented May 19, 2024 • edited Loading

BPerlakiH commented May 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BPerlakiH May 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BPerlakiH May 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rgaudin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kelson42 commented Jun 1, 2024

kelson42 commented Jun 6, 2024

BPerlakiH commented Aug 2, 2024

kelson42 commented May 19, 2024 •

edited

Loading

BPerlakiH May 24, 2024 •

edited

Loading

BPerlakiH May 21, 2024 •

edited

Loading