Fixed: Downloads were not automatically starting showing progress when reopening the app(If downloads paused due to any network error). #4130
+254
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4130 +/- ##
============================================
- Coverage 58.44% 58.35% -0.10%
- Complexity 1561 1568 +7
============================================
Files 316 316
Lines 13541 13597 +56
Branches 1727 1744 +17
============================================
+ Hits 7914 7934 +20
- Misses 4490 4511 +21
- Partials 1137 1152 +15 ☔ View full report in Codecov by Sentry. |
MohitMaliFtechiz
force-pushed
the
Issue#4106
branch
2 times, most recently
from
4859313 to
e8f0620
Compare
…when reopening the app. * Previously, if a download was stopped due to a network error and the Download Manager was waiting to retry, we were not receiving updates from the Download Manager. As a result, the download progress was not being displayed when the app was reopened. * Improved the service start mechanism: If the application is in the background, we now avoid starting the service because foreground services cannot be started when the application is not in the foreground.
…agment` which i accidentally faced while navigating very frequently to other screens.
…o network errors (especially during network fluctuations), as the Download Manager will retry after some time once the connection is restored.
…d due to network errors (e.g., network fluctuations). The application now correctly retrieves download progress from the DownloadManager and, if necessary, automatically resumes paused downloads without requiring user intervention. * Downloads paused due to network errors like "Waiting to Retry" are now resumed automatically when the network becomes available. * For downloads configured to only proceed on Wi-Fi, the application will resume progress when a Wi-Fi connection is re-established. Similarly, downloads queued for mobile networks will resume when the mobile network reconnects.
* After implementing the previous approach to track download progress during network fluctuations, a new issue occurred. Sometimes, when the user pauses a download, it resumes immediately without any user interaction. To address this, we introduced a new field to track the paused status, distinguishing whether the pause was initiated by the user or caused by the DownloadManager due to network fluctuations.
…even when they were paused due to no internet connection. We have added a check before pausing or resuming the download. If there is no internet connection, we now display the same "No Internet connection" snackbar message that is shown when attempting to download a book without an internet connection.
MohitMaliFtechiz
force-pushed
the
Issue#4106
branch
from
bd75de9 to
d2b6e7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4106
SearchFragmentwhich I accidentally saw while navigating very frequently to other screens.