Wrap new methods migrateBookmarks and getBestTargetBookId of libkiwix
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
force-pushed
the
bookmarks_migrations
branch
from
ab0cdbf to
58bff5f
Compare
|
@mgautierfr I have updated the code base to rely on libkiwix 13.1.0 and rebased this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
============================================
+ Coverage 92.51% 92.85% +0.34%
- Complexity 218 232 +14
============================================
Files 45 46 +1
Lines 294 308 +14
Branches 3 3
============================================
+ Hits 272 286 +14
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Sentry. |
- setBookName, getBookName - setBookFlavour, getBookFlavour
- migrateBookmarks - getBestTargetBookId
mgautierfr
force-pushed
the
bookmarks_migrations
branch
from
58bff5f to
fa44690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in Draft as it wrap a feature in libkiwix not yet released.
Once libkiwix is release, we have still have to change gradle script to use it and then we should be good.
Fix #84