Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable the generation of the "placeholders_order" element? #2

Open
stijnmelis opened this issue Aug 4, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@stijnmelis
Copy link

Hi,

I switched to your plugin since intl_translation has dependency problems.

Thanks for creating this fork, because it works fine, but I was wondering if it's possible to have a commandline option to disable the generation of the "placeholders_order" element in the arb files? This wasn't part of the files generated by intl_translation, and I already have quiet a large translated file (700+ translated strings), so I either have to redo the whole translated file, or it gets cumbersome to see the actual differences if I generate new files using your plugin. An option to not generate this element would help a lot.

Thanks!

@huynguyennovem
Copy link

same question. what's the purpose of this option? For placeholders order?

@jaumard
Copy link

jaumard commented Sep 28, 2021

Hello,

Thanks for the late reply, notification were disabled for this repo. The purpose of placeholders_order is to know the order of the different placeholders. That allows package like flutter_jimtl to be able to read ARB file on the fly directly in dart, and by the same occasion allow OTA updates for ARB files.

For sure an option can be added to not generate it. But we will not have time to do it as on our side we need it. But I will gladly review and merge a PR that allows this.

@jaumard jaumard added the help wanted Extra attention is needed label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants