Add missing commonMain folder to fuel-kotlinx-serialization project #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittinunf
reviewed
May 30, 2024
fuel-kotlinx-serialization/src/appleMain/kotlin/fuel/serialization/ResponseExtensions.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the
commonMainfolder to thefuel-kotlinx-serializationproject. ThecommonMainfolder is necessary for the Kotlin Multiplatform setup and was missing from the project.Changes Made
src/commonMaindirectory.expectfunctionHttpResponse.toJsonactualimplementations for every platformsMotivation and Context
This change is required to properly organize the common code shared across different Kotlin Multiplatform platform platforms. Without this folder, the project setup is incomplete and may lead to build issues.