Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix publishing task to include sourceJa after verification process is failing #905

Merged
merged 1 commit into from
May 19, 2024

Conversation

kittinunf
Copy link
Owner

@kittinunf kittinunf commented May 19, 2024

What's in this PR?

This PR fixes our gradle script a bit for publishing task when we publish the jar to sonatype.
Also it looks like we use alpha0x for naming convention so we are fixing that too.

@kittinunf kittinunf requested a review from iNoles May 19, 2024 09:50
@kittinunf kittinunf changed the title [Fix] Fix publishing task a bit after verification is failing [Fix] Fix publishing task to include sourceJa after verification process is failing May 19, 2024
Copy link
Collaborator

@iNoles iNoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it does add sourcejar correctly at this time with proper versions. Gradle seems to be okay with it too.

@iNoles iNoles merged commit 71219fd into main May 19, 2024
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the kv/fix-sources-jar-from-all-jvm-libraries branch May 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants