Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Split the API calling part into a library #6

Open
winstonma opened this issue Oct 21, 2021 · 3 comments
Open

[Feature Request] Split the API calling part into a library #6

winstonma opened this issue Oct 21, 2021 · 3 comments

Comments

@winstonma
Copy link

winstonma commented Oct 21, 2021

I love your work on telegram. And I would like to create a MagicMirror Module based on your backend.

I worked on one KMB ETA MagicMirror module and uses js-kmb-api as the KMB ETA API calling library. I really appreciate his work and his work is being used on my MagicMirror module as well as his frontend.

Just wonder if you would consider splitting your API calling code into a separate library so the code can be reused in different projects.

Thanks a lot

@kirosc
Copy link
Owner

kirosc commented Oct 23, 2021

Good idea. Sadly, I don't have any timeline for this. Feel free to fork the repo!

@winstonma
Copy link
Author

That's okay.

For my new MagicMirror module to work, if I need to work on the API calling part, I could

  • Study the API document
  • Drag the backend code onto my module, or
  • Create a backend module using your code, and then just call your module

I guess the last option should be the beneficial from a developer perspective but I think it is best if you keep updating the backend module (as you are the original developer). I could try the splitting work. I may start working on this during the weekends so it may take some time to finish.

ATM Let's keep this issue open

@winstonma
Copy link
Author

winstonma commented Dec 31, 2021

Hi @kirosc

Sorry to let you know that I am using MagicMirror's weather module as a base and this module use XMLHttpRequest (insider weatherprovider.js) which fetches data from the frontend. Therefore I would not need the backend fetcher.

Sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants