Proposed additions to plugin modernization PR #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://plugins.jenkins.io/gson-api/dependencies/ describes the technique. https://docs.google.com/document/d/1PKYIpPlRVGsBqrz0Ob1Cv3cefOZ5j2xtGZdWs27kLuw/edit#heading=h.bjcwbz77lxkb provides a more verbose description of the benefit of changing from a bundled library to instead use a Jenkins plugin that provides the previously bundled library.
https://plugins.jenkins.io/apache-httpcomponents-client-4-api/ describes the technique and how it can help plugin maintainers and Jenkins users. https://plugins.jenkins.io/apache-httpcomponents-client-4-api/dependencies/ gives the details to implement the change. https://docs.google.com/document/d/1PKYIpPlRVGsBqrz0Ob1Cv3cefOZ5j2xtGZdWs27kLuw/edit#heading=h.bjcwbz77lxkb provides a longer description.
https://plugins.jenkins.io/json-api/dependencies/ describes the technique. https://docs.google.com/document/d/1PKYIpPlRVGsBqrz0Ob1Cv3cefOZ5j2xtGZdWs27kLuw/edit#heading=h.bjcwbz77lxkb gives more details. Older versions of the JSON library (like this one) used a unique licensing scheme that has been changed in newer releases. The JSON API plugin uses a newer release. Using the JSON API plugin removes the version management chore from the plugin maintainer and leaves it with the maintainers of the plugin bill of materials.
The mockito-core version is managed by the parent pom, so it does not need to be specified in this pom file. The exclusions are no longer necessary. The wiremock testing library has changed its packaging and the current version is now at org.wiremock.wiremock-standalone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some changes that will reduce your work as a plugin maintainer and may also improve the experience for Jenkins users of the plugin. The changes include:
Tests pass on my Java 21 Linux computer with these changes and the plugin binary file is reduced from 1.6 MB to 53 KB