Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to benchmark speed performance of LASFile.read #444

Closed
1 of 3 tasks
kinverarity1 opened this issue Apr 16, 2021 · 4 comments
Closed
1 of 3 tasks

Provide a way to benchmark speed performance of LASFile.read #444

kinverarity1 opened this issue Apr 16, 2021 · 4 comments
Assignees

Comments

@kinverarity1
Copy link
Owner

kinverarity1 commented Apr 16, 2021

Is your feature request related to a problem? Please describe.
This is subjective, but I think it's fair to say LASFile.read is too slow. Compared to the performance that parsing a similarly-sized table using pandas.read_csv, it is very obviously slow. One of the big problems in improving this is the lack of reliable benchmarks to ensure we are improving performance.

Describe the solution you'd like
A simple way to see the performance of LASFile.read for one branch compared to another branch, in a reliable way. Then we can try out different code in attempts to improve the performance and see whether we're getting anywhere!

Describe alternatives you've considered
I've tried doing profiling locally but I've found depending on what else is happening on my machine at the time, the speeds vary quite widely. I also have no experience in setting up this kind of thing so am keen for any ideas.

** Solution **

@kinverarity1
Copy link
Owner Author

Implemented in #449 but could be improved - I've added a checklist to the issue description above.

@dcslagel
Copy link
Collaborator

dcslagel commented Apr 18, 2021

How about we move the checklist items to each be an issue. The benefit is that they will be visible and track-able at the issue level.

@kinverarity1
Copy link
Owner Author

Yep good idea I'll do that 👍

@kinverarity1
Copy link
Owner Author

See #457 and #458 for remaining tasks. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants