-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect annotator to DTS #19
Comments
The DTS collection is now saved into a json file on github automatically by an action on the ISicly repository. There web redirects have been set up for the collection endpoint and the documents:
The sub-collection of objects now visible in the annotator is built from that DTS collection. |
@JonPrag Jonathan, I think there are a few minor issues to address before completing the integration of the DTS redirects with the annotator:
The annotator fetches the documents using the "download" value in the collection member. Which is a raw git address. That's functional. I could use the new address of the document instead (e.g. http://sicily.classics.ox.ac.uk/inscription/ISic000001.xml), but that would be built using external logic to the DTS collection. The collection itself doesn't provide any clue about that address. The DTS way to obtain the document is either with the download attribute (although this bypasses the document endpoint) by passing the member ID to the document endpoint: e.g. https://sicily.classics/ox.ac.uk/dts/document?id=https://sicily.classics.ox.ac.uk/inscription/ISic000001) Anyway, I think there are two options available for the references to the documents: a. is simple and already work. But we need to understand that the project claims about DTS compliance should remain quite low. There's no way someone would be able to use a DTS client only to interact with the texts. They'd need to inject some project-specific logic; which, as I explained before, is defeating the point of DTS. b. would improve that a bit, but may not be worth it if we are happy with something functional as it is. |
@geoffroy-noel-ddh thanks for this.
Will await your answer to (4) in particular before I pursue with James (who I hope will be able to make these minor tweaks, but is otherwise now unavailable). |
Hi @JonPrag , Apologies for the delay. Re. your question under point 4.
I hope that clarifies things a bit? Now... one thing I discovered is that the DTS spec has been recently updated. With breaking changes! And the doc of the previous version (which the Annotator and your collection follow) wasn't easily accessible online last time I checked. One of the breaking changes is the parameter name for obtaining a doc by its ID. So instead of ?id=DOCUMENTID it is now ?resource=DOCUMENTID. https://distributed-text-services.github.io/specifications/versions/1-alpha/#document-endpoint If we want to match the latest version of DTS, we'd both have to upgrade the code at each end. And there might be other backward incompatible changes. I haven't assessed the extend of the changes needed to updated compliance. Alternatively we could imply agree to match the previous version (1-draft2 rather than the newly released 1-alpha). If there's enough time, desire and resource for it we could upgrade to the latest version by the end of the project. But for now I'd recommend just stay aware that the official spec no longer support our implementation. |
Once a DTS server is up and running on the Oxford infrastructure the Annotator can pulled the collection and perhaps more metadata/content from it.
Annotator is currently using a static copy of the DTS collection generated in Nov 2022 from the DTS PoC and the github repository.
The text was updated successfully, but these errors were encountered: