Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jellyfin internal subtitles are not detected when using Jellyfin on a base path different than / #586

Open
PaulMcCarthy401 opened this issue Dec 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@PaulMcCarthy401
Copy link

What is the issue
Jellyfin internal subtitles are not detected

What do you do to make it happen
On both Jellyfin 10.9.11 and 10.10.3, load a video with internal subtitles (automatically loaded from the .srt file which is in the same directory as the video file). Confirm that the expected subtitle is being used from the CC menu, and if not, select it. I have "Auto-load detected subtitles", so the internal subtitles should be loaded automatically. From there:

  • asbplayer's subtitle view won't start up.
  • the side panel shows "Load subtitles onto a video to start using asbplayer."
  • Clicking "Load Subtitles" from the asbplayer right-click menu opens the "Select Subtitles" modal with all three "Subtitle Track" dropdowns showing "Empty" and containing no options.
  • Jellyfin plays with regular .srt subtitles showing, not asbplayer's.

Loading external subtitles with drag-and-drop does still work.

What browser?

  • Chrome 131.0.6778.140
  • Brave 1.71.121
    All other extensions disabled, as well as Brave Shields

Is it happening with local video or streaming video?
Streaming

If the issue is happening with streaming video, what version of the extension are you using?
v1.6.1

If the issue is happening with streaming video, on what website(s) is the issue happening?
Jellyfin

@PaulMcCarthy401
Copy link
Author

The reason I couldn't find pages/emby-jellyfin-page.ts was because it wasn't actually being loaded at all since my Jellyfin is hosted at myexampleserver.com/jellyfin/, which doesn't match against the rules in pages.json. Changing the rule in pages.json to match on the path instead fixed that issue, but pages/emby-jellyfin-page.ts doesn't handle the basepath so it tries to download subs from myexampleserver.com/Videos/... and not myexampleserver.com/jellyfin/Videos/...

I'll rename the issue.

@PaulMcCarthy401 PaulMcCarthy401 changed the title Jellyfin internal subtitles are not detected Jellyfin internal subtitles are not detected when using Jellyfin on a base path different than / Dec 16, 2024
@killergerbah killergerbah added the enhancement New feature or request label Dec 31, 2024
@henryphz
Copy link

henryphz commented Jan 5, 2025

Also have that issue on my media server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants