Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete obsolete AWS files #555

Open
wants to merge 7 commits into
base: v3
Choose a base branch
from

Conversation

jdmooney
Copy link
Contributor

@jdmooney jdmooney commented Jun 3, 2024

awf-cf.adoc replaced how-to-set-up-a-cloud-formation-system.adoc/how-to-maintain-a-cloud-formation-system.adoc
aws-multitier.adoc replaced by how-to-set-up-a-multi-tier-system.adoc/how-to-maintain-a-multi-tier-system.adoc
aws-singletier.adoc replaced by how-to-set-up-a-single-tier-system.adoc/how-to-maintain-a-single-tier-system.adoc
aws-single-ami.adoc obsolete. No need to replace.

Copy link
Contributor

@reshmabidikar reshmabidikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment: Doesn't aws-tools.adoc need to be deleted as done in the earlier PR?

@vnandwana
Copy link
Contributor

The aws-cf.doc has info about updating stack, this is missing in the replaced doc. Could you please take a look? Thank you.

@jdmooney
Copy link
Contributor Author

jdmooney commented Jun 9, 2024

@vnandwana could you be more specific? I don't think I am finding the content you are referring to.

@vnandwana
Copy link
Contributor

vnandwana commented Jun 10, 2024

@jdmooney, sure, aws-cf.adoc has information about updating a CloudFormation stack (see https://github.com/killbill/killbill-docs/blob/v3/userguide/tutorials/aws-cf.adoc#update-configuration).

This information is missing in the docs that has replaced the aws-cf.adoc. We need to add a section in the how-to-set-up-a-cloud-formation-system.adoc/how-to-maintain-a-cloud-formation-system.adoc about updating the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants