[ISSUE 199] Log commit hash while describing checkout/merge #202
Conversation
| logger.info( | ||
| `[${node.project}] Merging ${context.config.github.serverUrl}/${node.project}:${checkoutInfo.targetBranch} into ${context.config.github.serverUrl}/${checkoutInfo.group}/${checkoutInfo.project}:${checkoutInfo.branch}` | ||
| `[${node.project}] Checking out ${context.config.github.serverUrl}/${node.project}:${checkoutInfo.targetBranch} ${targetHash} and merging ${context.config.github.serverUrl}/${checkoutInfo.group}/${checkoutInfo.project}:${checkoutInfo.branch} ${sourceHash} into '${dir}'` |
There was a problem hiding this comment.
@danielezonca if you don't want to check the whole thing just check the log information is the one expected. Be aware getRemoteSha prefixes the hash with a @ Thanks
| * @param {string} branch the branch to get the hash from | ||
| */ | ||
| async function remoteSha(repositoryUrl, branch) { | ||
| return await git(".", "ls-remote", repositoryUrl, branch); |
There was a problem hiding this comment.
@almope do you think there is a better way to get hash from a remote repository? 🤔 thanks!
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@kie/build-chain-action", | |||
| "version": "2.3.25", | |||
| "version": "2.3.26", | |||
There was a problem hiding this comment.
Why the changelog mentions 2.6.2 while here is 2.3.26? Is it because the disalignment we discussed between branch/tag and actual version?
| * | ||
| * @param {string} repositoryUrl the repository URL | ||
| * @param {string} branch the branch to get the hash from | ||
| * @param {number} hashLength the length of hash to return back |
There was a problem hiding this comment.
Is there a way to get the full hash without knowing the length? I quickly checked git documentation and it seems there are different ways to configure git hashing so I assume this can lead to different hash size
https://git-scm.com/docs/hash-function-transition/
There was a problem hiding this comment.
let me check the documentation
| */ | ||
| async function getRemoteSha(repositoryUrl, branch, hashLength = 7) { | ||
| try { | ||
| const remoteHashValue = await git.remoteSha(repositoryUrl, branch); |
There was a problem hiding this comment.
I'm not familiar with this code so I don't know if the question makes sense but is this invoking normal git CLI command or is it a GitHub remote API call?
I remember in the past we had failures related to the number of API call so I want to double check if this is increasing the number of calls we do or not.
There was a problem hiding this comment.
it is actually a very good question. This is executing the remoteSha method from git.js file which basically at the end executes the git CLI tool from the filesystem.
|
out of date |
Thank you for submitting this pull request
fix #199