Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor from CommonJS to ES Modules. #25

Open
radiohertz opened this issue May 6, 2020 · 1 comment
Open

refactor from CommonJS to ES Modules. #25

radiohertz opened this issue May 6, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@radiohertz
Copy link
Contributor

I've noticed we've been using CommonJS modules. I Think we can refactor to use ES modules as we are already using babel. Also, I think webpack is unnecessary as the build will be on a server and the bundle size wont matter.

@jeffin143 @sastaachar what do you think?

@jeffin143
Copy link
Contributor

I Think we can refactor to use ES modules as we are already using babel

Yes we can use ES modules

About webpack , we may need it for docs since we would be hosting it along with server and other things ahead , I don't mind keeping it, that was initial setup but now I can see that might come in handy

@radiohertz radiohertz added the good first issue Good for newcomers label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants