Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all forms to submit on enter #55

Open
emcniece opened this issue Apr 17, 2016 · 0 comments
Open

Convert all forms to submit on enter #55

emcniece opened this issue Apr 17, 2016 · 0 comments

Comments

@emcniece
Copy link
Collaborator

Currently there is a mixture of keypress detection and form submission handling. These should be unified: instead of watching for keypresses, each form should handle a submit event and cancel the default action.

This issue might be useful. Some forms have specific functions (#login for example) that need to be called on submission. If the function name is stored in a data-action="do_login" format, we can avoid a switch in the form submission handler and stick with a global form submission statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant