Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional user settings #42

Open
emcniece opened this issue Apr 9, 2016 · 1 comment
Open

Additional user settings #42

emcniece opened this issue Apr 9, 2016 · 1 comment
Labels

Comments

@emcniece
Copy link
Collaborator

emcniece commented Apr 9, 2016

There are some other interfaces that could benefit from having stored settings:

  • Sidebar dropdown status
  • Max terminal line count

It may be worth changing the localStorage settings to a more generic abstraction layer at this point. An HTML attribute like [data-setting] could bind a click/change/touch event to the element that would trigger save_settings and store all element data with this particular data attribute.

@emcniece emcniece changed the title Additional user settigs Additional user settings Apr 17, 2016
@emcniece
Copy link
Collaborator Author

Related: #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant