Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Конфигурации топов словарей должны читаться из файла, а не из кучи классов #98

Open
dmitry-weirdo opened this issue Nov 20, 2024 · 0 comments
Open

Конфигурации топов словарей должны читаться из файла, а не из кучи классов #98

dmitry-weirdo opened this issue Nov 20, 2024 · 0 comments

Comments

@dmitry-weirdo
Copy link
Collaborator

dmitry-weirdo commented Nov 20, 2024 •
edited
Loading

Конфигурация вроде OneHundredRussianTopExporter — это избыточный оверкилл. Логично читать подобные конфигурации из json-файла, чтобы настраивать словари можно было более-менее динамически, не меняя код.

Также надо подумать, как включать/выключать словари в конфиге вроде statistics-generator-config-generate-all.json (класс StatisticsGeneratorConfig).

Аналогично для NonStandardDictionary.
NonStandardDictionary нужно оставить тем же объектом, но читать из файла вместо хардкодинга. Получать из кэша по коду словаря (числовому айдишнику)

Более того, полный список словарей потом можно будет загрузить из csv-файла Переборыча. Но там нет названия в родительном падеже. Но их можно загружать отдельно, уже из внешнего файла (необходимо только для словарей, которые используются в топах).

Также, это избавит от необходимости придумывать имя для значения энума, как сейчас в NonStandardDictionary.
dmitry-weirdo added a commit that referenced this issue Nov 26, 2024
@dmitry-weirdo
feat: #98 Add a draft of how a non-standard dictionaries configuratio…
6f5af54 
…n can look like. Add dictionary tags enum.
dmitry-weirdo added a commit that referenced this issue Nov 26, 2024
@dmitry-weirdo
feat: #98 Add the draft Kotlin classes of non-standard dictionaries t…
43feea3 
…hat will be loaded from the json configuration.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 First version of a class that parses the non-standard dicti…
fbfb209 
…onaries data from json file into list of Kotlin objects.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Validate that there are no dictionary code duplicates in th…
d7530b4 
…e json file.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 #96 Add the required English dictionaries to the json file.…
276e2be 
… Excel sheet names not yet overloaded.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Add "Цифросоточка" dictionary mapping.
55330fb
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Add fingers dictionaries mapping (those dictionaries that a…
2a65852 
…re used in the tops generation).
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Typo fix in the logger name for "ring fingers" dictionary.
542de84
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Add dictionaries mapping for Hrust exercises (they all have…
43f4777 
… no tops yet).
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Started a draft of a class that will generate the `NonStand…
d68f5a2 
…ardVocabularyTopExporter` based on the data from the json file.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Add an etalon generated stats from 2024.11.11, copied from …
7dc62c1 
…the s3 bucket to where it was put by a GitActions job.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Add the statistics generated by pre-Kotlin app.
8824b12
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Add a script to delete everything from the /stats directory…
c610c8f 
… (in our case it's `kgstats-generated/2024.11.11/stats`.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
docs: #98 Added documentation on how I execute the stats re-generatio…
37683cf 
…n. Add the related json configs.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Re-generated the stats from the current database of 2024.11…
0c2c981 
….11. Just xls and zip files changes + comments in the static css files.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 In the VocabularyTopExporter hierarchy, return loggerName a…
ed1a241 
…nd use a single LoggerWrapper that will append this loggerName to the logs.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Re-generated the stats from the current database of 2024.11…
f66734c 
….11. Just xls and zip files changed.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 Started generalization of the NonStandardVocabularyTopExpor…
73f4594 
…ter implementations - use minRacesCount and loggerName from cache. Excel data not yet.
dmitry-weirdo added a commit that referenced this issue Nov 27, 2024
@dmitry-weirdo
feat: #98 In NonStandardDictionariesCache, map dictionaries by code…
0c172a1 
… and return from map when querying by dictionaryId.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 Use the overrridden Excel sheet names also from json file i…
65d831d 
…nstead of hard-coding in the exporters.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 Re-generated the stats from the current database of 2024.11…
ef3873f 
….11. Just xls and zip files changed.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 Remove NonStandardDictionary usage from NonStandardVocabula…
b5eca09 
…ryTopExporter and VocabularyTopUtils.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
refactor: #98 Add a common method to get the "first page in top by sp…
bff1fe1 
…eed" for any dictionary instead of passing the same page number every time.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 Re-generated the stats from the current database of 2024.11…
a59e3a8 
….11. Just xls and zip files changed.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 Add more examples to the Freemarker example template. Save …
1ee9b0f 
…it to file.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 Extract dictionary names in the statistics header from hard…
57ee6e5 
…coded values in `header.ftl` into dictionary parameters.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 Re-generated the stats from the current database of 2024.11…
6286c19 
….11. Just xls and zip files changed.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 To turn the non-standard dictionaries generation on and off…
47d4a5e 
…, use a list of integer dictionary ids instead of separate boolean flags.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
fix: #98 Fix the invalid config json comment.
951ede1
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 Generate the non-standard dictionaries exporters dynamicall…
c51517a 
…y, based on config. Pass the `PlayerVocabularyStatsRepository` from `StatisticsGenerator`.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 Re-generated the stats from the current database of 2024.11…
ffb8c14 
….11. Just xls and zip files changed (118 files total).
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 In Links, use the non-stadard dictionaries context instead …
b16a9aa 
…of hard-coded implementations. Old implementations finally removed.

- Far from perfect, but a nice intermediate state.
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
feat: #98 Re-generated the stats from the current database of 2024.11…
fd21414 
….11. Just xls and zip files changed (118 files total).
dmitry-weirdo added a commit that referenced this issue Nov 28, 2024
@dmitry-weirdo
refactor: #98 Extract the creation of mock ExportContext into a spe…
057caed 
…cific class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitry-weirdo