New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use mutable defaults #10

Open

peterbe opened this issue Apr 22, 2019 · 0 comments

Labels

Contributor

peterbe commented Apr 22, 2019

E.g.

python-keycdn-api/keycdn/keycdn.py

Line 34 in 73dd2d6

def get(self, call, params={}):

Instead of:

def get(self, call, params={}):
    ...

it needs to be:

def get(self, call, params=None):
    params = params or {}

See https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments

svenba added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment