Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too many comments? #70

Open
alchmy opened this issue Dec 22, 2018 · 1 comment
Open

too many comments? #70

alchmy opened this issue Dec 22, 2018 · 1 comment

Comments

@alchmy
Copy link

alchmy commented Dec 22, 2018

I love what you are doing here, and am trying to grok the source so that I know how to use parts of the library for a project of my own. I am wondering about the code style, is it really necessary to include all the extra comments and versioning information ? Isn't the purpose of git to handle versioning?

https://github.com/keybase/triplesec/blob/master/src/enc.iced

@AndersTornkvist
Copy link

There are comments in the code so that others can understand the code easier.

As for the versions, there are actually (currently) four different versions of the TripleSec format. The current implementation needs to be able to decrypt messages from previous versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants