-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to fail performance test if one version is significantly slower then another. #88
Comments
My working theory is something like this: var versions = [
['super-old', ICAL_Y],
['previous', ICAL_X],
['latest', ICAL]
]; The new benchmarking framework will run through each and fail if latest is significantly slower then another version.... I will probably make this opt-in something like the following: perf.suite(function(perf) {
/* fail tests in this suite if latest is more then 20% slower then any other version */
perf.failThreshold(0.2);
}); |
@kewisch feedback? |
Yes, sounds good to me. It would also be good if there were some perf report that summarizes the difference per test and even better if this were visible on the travis build. |
@kewisch I will see what I can do- for now keep in mind (if you have not seen this already) that we currently dump this information in travis now. We just don't do any fancy error throwing if things are slower ;( |
I've disabled the perf tests on CI to save some cycles, as the new test I have added in c50c765 takes a while to complete. |
I'm going to close this for a bit of cleanup, if someone comes in with a need for perf testing and has smart ideas on how to run them in a reliable fashion on github actions CI, I'm all for it. |
No description provided.
The text was updated successfully, but these errors were encountered: