Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any breaking changes when going from v1.5 to v2.0? #650

Closed
jungalwala opened this issue Apr 1, 2024 · 3 comments
Closed

Any breaking changes when going from v1.5 to v2.0? #650

jungalwala opened this issue Apr 1, 2024 · 3 comments

Comments

@jungalwala
Copy link

Are there any breaking changes when migrating from v1.5 to 2.0?

Jay

@kewisch
Copy link
Owner

kewisch commented Apr 1, 2024

Based on my recollection of the ES6 changes, a quick skim through the diff, and an educated guess based on the changelog, I don't think there are any breaking changes. There may be some differences on how the library is imported given the ES6 changes and how node works, but this should be trivial.

I mainly did the bump to 2.0 out of an abundance of caution given the ES6 changes.

@kewisch
Copy link
Owner

kewisch commented Apr 1, 2024

Ah yes, there are some breaking changes w.r.t. imports and browsers. You can't simply <script src> import it there, you'll need

<script type="module">
import ICAL from "https://unpkg.com/ical.js";

// ...
</script>

The es5 version will need some massaging so that it would work in a browser, right now it just sets module.exports, I need to file an issue to update the README and es5 version for browser use.

@kewisch
Copy link
Owner

kewisch commented Apr 8, 2024

Closing this in favor of the other issue

@kewisch kewisch closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants