Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mishandling of escaped quotes in attendee names #482

Closed
thexeos opened this issue Nov 17, 2021 · 3 comments
Closed

Mishandling of escaped quotes in attendee names #482

thexeos opened this issue Nov 17, 2021 · 3 comments

Comments

@thexeos
Copy link

thexeos commented Nov 17, 2021

Running this through validator returns mangled output:

BEGIN:VCALENDAR
BEGIN:VEVENT
ATTENDEE;CN="Firstname \"Nickname\" Lastname";PARTSTAT=NEEDS-ACTION:/id/
END:VEVENT
END:VCALENDAR

One result of this is inconsistent display of participant names in Thunderbird:

In the email viewer itself (for emails with ICS attachment), the preview box cuts off attendee name at first escape character (backslash):
image

After adding event to calendar, the event details window captures text beyond the semicolon:
image

@dilyanpalauzov
Copy link
Contributor

dilyanpalauzov commented Apr 15, 2022

The correct RFC6868-presentation of the above data is ATTENDEE;CN=Firstname ^'Nickname^' Lastname;PARTSTAT=NEEDS-ACTION:/id/.

The problem report does not describe how to reproduce the problem. In particular it is unclear, whether ical.js has problems parsing ATTENDEE;CN="Firstname \"Nickname\" Lastname";PARTSTAT=NEEDS-ACTION:/id/ as input, or if ical.js returns ATTENDEE;CN="Firstname \"Nickname\" Lastname";PARTSTAT=NEEDS-ACTION:/id/ as output.

As far as the above text is used as input to the validator, the input is wrong.

#507 does improve handling of parsing of parameter values with ^-escapes.

@ray007
Copy link

ray007 commented Feb 24, 2023

I think I have a related problem: parsing events from ics data I get an ICAL.Event with a color property set to "rgb(81\\,114\\,60)".
Shouldn't there be some decode/encode on parsing/serializing?

@kewisch
Copy link
Owner

kewisch commented Apr 1, 2024

I'm not 100% sure this is a bug or works as intended. What @dilyanpalauzov says seems to suggest everything is working properly? Would appreciate a reopen or new issue in case I missed something.

@kewisch kewisch closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants