Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build artifacts from tree #405

Closed
kewisch opened this issue Oct 20, 2019 · 3 comments
Closed

Remove build artifacts from tree #405

kewisch opened this issue Oct 20, 2019 · 3 comments

Comments

@kewisch
Copy link
Owner

kewisch commented Oct 20, 2019

I used to like having build/ical.js and sorts in the tree because it was easy to get started and just grab the file. I've since changed my mind, the constant browser builds and differences in minification have been pretty annoying. I'm removing the artifacts now.

I'm later going to set up automation so that when publishing to NPM there is an ical.js file to use. I'll also have to figure out if this breaks the cdnjs integration.

kewisch added a commit that referenced this issue Oct 20, 2019
kewisch added a commit that referenced this issue Oct 20, 2019
@twinklebob
Copy link

This has broken the jsFiddle and validator which both used the version from the build folder. I agree with moving them from source control, but you now need to have another version available for testing.

@kewisch
Copy link
Owner Author

kewisch commented Oct 24, 2019

Got it, thanks for the note. I'll find a solution for that soon, possibly when I have automation set up. Maybe I can have it link to the latest artifact from github actions.

@kewisch
Copy link
Owner Author

kewisch commented Apr 1, 2024

With unpkg and new automation, we should be good now.

@kewisch kewisch closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants