You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for providing this extension - it is very useful!
One situation where shift-enter is already taken by vanilla VSCode is in notebook files (https://code.visualstudio.com/blogs/2021/11/08/custom-notebooks), where it triggers the "Notebook: Execute Notebook Cell and Select Below" command. This keybinding has been around in IPython for many years, and it very surprising to be overridden there - event more so as the way this extension configures this, it also overrides the shortcut when the cursor is not at all on a comment line.
Would it be an option to extent the when condition to editorTextFocus && !notebookEditorFocused, to avoid stealing the shortcut? I might additionally be useful to add a new, untaken shortcut for "escaping" from a comment in notebooks, maybe one more modifier.
I would be happy to send a change, if you would accept it.
The text was updated successfully, but these errors were encountered:
Thanks for providing this extension - it is very useful!
One situation where shift-enter is already taken by vanilla VSCode is in notebook files (https://code.visualstudio.com/blogs/2021/11/08/custom-notebooks), where it triggers the "Notebook: Execute Notebook Cell and Select Below" command. This keybinding has been around in IPython for many years, and it very surprising to be overridden there - event more so as the way this extension configures this, it also overrides the shortcut when the cursor is not at all on a comment line.
Would it be an option to extent the when condition to
editorTextFocus && !notebookEditorFocused
, to avoid stealing the shortcut? I might additionally be useful to add a new, untaken shortcut for "escaping" from a comment in notebooks, maybe one more modifier.I would be happy to send a change, if you would accept it.
The text was updated successfully, but these errors were encountered: