Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not "steal" shift-enter in notebooks #46

Open
rehmsen opened this issue Aug 23, 2024 · 0 comments
Open

Should not "steal" shift-enter in notebooks #46

rehmsen opened this issue Aug 23, 2024 · 0 comments

Comments

@rehmsen
Copy link

rehmsen commented Aug 23, 2024

Thanks for providing this extension - it is very useful!

One situation where shift-enter is already taken by vanilla VSCode is in notebook files (https://code.visualstudio.com/blogs/2021/11/08/custom-notebooks), where it triggers the "Notebook: Execute Notebook Cell and Select Below" command. This keybinding has been around in IPython for many years, and it very surprising to be overridden there - event more so as the way this extension configures this, it also overrides the shortcut when the cursor is not at all on a comment line.

Would it be an option to extent the when condition to editorTextFocus && !notebookEditorFocused, to avoid stealing the shortcut? I might additionally be useful to add a new, untaken shortcut for "escaping" from a comment in notebooks, maybe one more modifier.

I would be happy to send a change, if you would accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant