Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Dropwizard 4.0 #1031

Closed
2 tasks done
lfoppiano opened this issue Jun 19, 2023 · 4 comments
Closed
2 tasks done

Update to Dropwizard 4.0 #1031

lfoppiano opened this issue Jun 19, 2023 · 4 comments
Labels
enhancement implemented The issue has been implemented
Milestone

Comments

@lfoppiano
Copy link
Collaborator

lfoppiano commented Jun 19, 2023

I've started looking into upgrading from dropwizard 1.x to 4.x. It's quite some work but doable. I've got already a working version of grobid-quantities. 😄

I've started working on the branch features/update-dropwizard.

There are two-three main changes to be done:

  • [ ] update the GrobidServiceConfiguration to cover all the elements from the YAML (it seems more strict than dropwizard 1
  • [ ] (probably) get rid of the GrobidProperties
  • Move the output bytecode from jdk 1.8 to jdk 1.11
  • Fix HealthCheck
  • [ ] Fix tests to run with Junit 5 (org.junit.internal.runners.rules.ValidationError: The @ClassRule 'APP' must implement TestRule.)

I will update this thread as I progress

@lfoppiano lfoppiano added this to the 0.8.0 milestone Jun 19, 2023
@kermitt2
Copy link
Owner

kermitt2 commented Nov 13, 2023

I think the main problem for this upgrade is that the JDK 1.8 compatibility is lost.
In my tests, I had some difficulties replacing dropwizard-guicier by the more modern dropwizard-guicey for the guice stuff support in the new Dropwizard, I did not manage to bind the classes to the module, but I see that you made it in #1032 !

@lfoppiano
Copy link
Collaborator Author

#1032 should be working fine except for the tests that are running with the legacy engine

@kermitt2
Copy link
Owner

Nice! What about adding it to the 0.8.0 release and move to Java 11 as minimal requirement?

@lfoppiano
Copy link
Collaborator Author

@kermitt2 I think it's time to let JDK 1.8 go 😄

@lfoppiano lfoppiano added the implemented The issue has been implemented label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement implemented The issue has been implemented
Projects
None yet
Development

No branches or pull requests

2 participants