Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Renovate update Makefile versions as well #314

Closed
mowies opened this issue Nov 7, 2022 · 0 comments · Fixed by #431
Closed

Make Renovate update Makefile versions as well #314

mowies opened this issue Nov 7, 2022 · 0 comments · Fixed by #431
Assignees
@mowies
Labels
chore Maintenance
Milestone
0.5.x

Comments

@mowies
Copy link
Member

mowies commented Nov 7, 2022 •
edited
Loading

Right now, Renovate doesn't take the Makefiles into account during version upgrades (as can be seen in the Detected dependencies here).

It would be very cool to get Renovate to update the versions in there as well, same as also in the pipeline.
Especially the k8s version at https://github.com/keptn/lifecycle-toolkit/blob/main/scheduler/Makefile#L33 would make a lot of sense, since that one actually has a lot of impact in the software.

Renovate can work with custom regexes to update things as well: https://docs.renovatebot.com/modules/manager/regex/
@thschue thschue added this to the 0.5.x milestone Nov 9, 2022
@thschue thschue added the chore Maintenance label Nov 11, 2022
@mowies mowies mentioned this issue Nov 17, 2022
Merged
@mowies mowies self-assigned this Nov 17, 2022
@mowies mowies moved this to 🏃 In progress in Keptn Lifecycle Toolkit Nov 17, 2022
@mowies mowies closed this as completed in 2ad37e9 Nov 17, 2022
Repository owner moved this from 🏃 In progress to ✅ Done in Keptn Lifecycle Toolkit Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mowies mowies

Labels
chore Maintenance
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
0.5.x
Development

Successfully merging a pull request may close this issue.

ci: have renovate update Makefile dependencies mowies/lifecycle-controller
2 participants
@mowies @thschue