Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a possibility to configure number of retries and interval for KeptnEvaluationDefinition #3132

Closed
Tracked by #218
odubajDT opened this issue Feb 27, 2024 · 0 comments · Fixed by #3141
Closed
Tracked by #218

Introduce a possibility to configure number of retries and interval for KeptnEvaluationDefinition #3132

odubajDT opened this issue Feb 27, 2024 · 0 comments · Fixed by #3141
Assignees
@odubajDT
Labels
enhancement New feature or request lifecycle-operator

Comments

@odubajDT
Copy link
Contributor

Description

KeptnEvaluation has a possibility to configure the number of retries (.spec.retries) and the retry interval (.spec.retryInterval). For a user using the lifecycle management functionality of Keptn it is not possible to configure those parameters via KeptnEvaluationDefinition as KeptnEvaluation is generated automatically by Keptn.

It is possible to configure them only if the user is creating KeptnEvaluation manually.

https://github.com/keptn/lifecycle-toolkit/blob/main/lifecycle-operator/apis/lifecycle/v1beta1/keptnevaluation_types.go#L52
https://github.com/keptn/lifecycle-toolkit/blob/main/lifecycle-operator/apis/lifecycle/v1beta1/keptnevaluationdefinition_types.go#L24

Expected behavior

We should allow users to configure the above mentioned parameters via KeptnEvaluationDefinition in the same manner, as we currently have it for Keptn tasks in general

https://github.com/keptn/lifecycle-toolkit/blob/main/lifecycle-operator/apis/lifecycle/v1beta1/keptntaskdefinition_types.go#L43
https://github.com/keptn/lifecycle-toolkit/blob/main/lifecycle-operator/apis/lifecycle/v1beta1/keptntask_types.go#L54
@odubajDT odubajDT added bug Something isn't working lifecycle-operator enhancement New feature or request and removed bug Something isn't working labels Feb 27, 2024
@odubajDT odubajDT mentioned this issue Feb 27, 2024
Closed
@odubajDT odubajDT added the status: ready-for-refinement Issue is relevant for the next backlog refinment label Feb 27, 2024
@odubajDT odubajDT self-assigned this Feb 28, 2024
@odubajDT odubajDT removed the status: ready-for-refinement Issue is relevant for the next backlog refinment label Feb 28, 2024
@mowies mowies moved this to 🎟️ Refined in Keptn Lifecycle Toolkit Feb 28, 2024
@mowies mowies moved this from 🎟️ Refined to 🏃 In progress in Keptn Lifecycle Toolkit Feb 28, 2024
@odubajDT odubajDT mentioned this issue Feb 28, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏃 In progress to ✅ Done in Keptn Lifecycle Toolkit Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odubajDT odubajDT

Labels
enhancement New feature or request lifecycle-operator
Projects
Keptn Lifecycle Toolkit
Archived in project
Milestone
No milestone
1 participant
@odubajDT