Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests fail for keptn version < 0.18.x (expected) and create a Github issues #71

Open
10 tasks
vadasambar opened this issue Sep 22, 2022 · 5 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@vadasambar
Copy link
Collaborator

vadasambar commented Sep 22, 2022

Summary
Current code in master branch of the datadog-service is incompatible with Keptn versions < 0.18.x due to a breaking change in Keptn. We run the integration tests for 5 Keptn versions

keptn-version: ["0.16.0", "0.17.0", "0.18.1", "0.19.0"] # https://github.com/keptn/keptn/releases

When the tests run, the workflow fails for 0.16.0 and 0.17.0 version of Keptn which is expected but it creates a Github issue of type:critical (example 1, example 2) which can confuse people.
We should remove the 0.16.0 and 0.17.0 version from the workflow above.

Affected Component

  • Web UI / Bridge
  • CLI
  • REST API or webhooks
  • User experience
  • Developer experience
  • Deployment/management with Helm

To Reproduce
The integration tests workflow runs every day. You can check a new issue of type:critical is created everyday in https://github.com/keptn-sandbox/datadog-service/issues

Expected behavior
The workflow should not create a Github issue
Current behavior
The workflow creates a Github issue everyday.

Screenshots

Additional context

TODO

  • Remove 0.16.0 and 0.17.0 from the integration tests above
  • Make sure the Integration tests pass by running it for your PR branch from here
    image
  • Paste a screenshot or a link in the PR
  • Get the PR reviewed and merge
  • DONE
@vadasambar vadasambar added bug Something isn't working good first issue Good for newcomers labels Sep 22, 2022
@vadasambar
Copy link
Collaborator Author

Failure on 23rd Sep 2022: #74

This was referenced Sep 27, 2022
@tarangverma
Copy link
Contributor

can i work on this issue.

@vadasambar
Copy link
Collaborator Author

@tarangverma yes and thank you for showing interest. I will assign the issue to you.

@vadasambar
Copy link
Collaborator Author

vadasambar commented Sep 29, 2022

If you need help, you can reach out to me on keptn slack (username: @vadasambar)

@tarangverma
Copy link
Contributor

sure, thankyou...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants